]> git.neil.brown.name Git - history.git/commit
[PATCH] add missing #include
authorDenis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Sat, 1 May 2004 10:32:45 +0000 (03:32 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Sat, 1 May 2004 10:32:45 +0000 (03:32 -0700)
commite663d7c9816d6386e2c9b1bfb992b5c328ce4e4f
tree21637a453211ca69dcb404e9d7d942128689f8db
parentd14c946e0796521887935a69e645ed695806c1fc
[PATCH] add missing #include

There's a subtle problem with "inline" usage in <linux/string.h>:

 <linux/string.h>:
        this pulls in __constant_c_and_count_memset()

 <linux/mm.h>:
        this pulls <compiler.h>, re-defining
        inline == __inline__ __attribute__((always_inline)).

 But by now it is too late! The compiler has already seen the bare
 "inline" in string.h, and hasn't inlined it.

Result:

# grep __constant System.map
c0144670 t __constant_c_and_count_memset
c0145c60 t __constant_c_and_count_memset
... many more copies of this function ...

Fixed by including <compiler.h> early enough.
include/linux/string.h