popup: fix popup_child_notify

Two silly typos meant this didn't work properly.

Signed-off-by: NeilBrown <neil@brown.name>

diff --git a/DOC/TODO.md b/DOC/TODO.md
index 39b663938a0e946089b1fac8f5910704c3554d3d..2711a537c3022ab80d42937e757a2bd4bef32e11 100644 (file)
--- a/DOC/TODO.md
+++ b/DOC/TODO.md
@@ -25,7 +25,7 @@ the file.
       time.
       When searching backwards and result is just above display, the
       result doesn't get shown.  Sometimes.
-- [ ] visiting a new file from a 44 popup is weird.
+- [X] visiting a new file from a 44 popup is weird.
 - [ ] search in history always finds a new history line.  It doesn't
       check if new patterns still matches this line.
 - [ ] in notmuch cursor should go to query result when changing

diff --git a/lib-popup.c b/lib-popup.c
index 793651de0ac347b287fe5a16546c46403d3ebbc2..06e858d715451a447a78a2aa0b7305cdf1029b97 100644 (file)
--- a/lib-popup.c
+++ b/lib-popup.c
@@ -415,13 +415,13 @@ DEF_CMD(popup_child_notify)
                return 1;
 restart:
        list_for_each_entry(old, &p->children, siblings) {
-               if (c->z == 0)
+               if (c->z != 0)
                        /* Ignore */
                        continue;
                if (old == c)
                        /* This pane is under control... */
                        continue;
-               if (c->damaged & DAMAGED_CLOSED)
+               if (old->damaged & DAMAGED_CLOSED)
                        continue;
                if (ci->num > 0) {
                        /* Not the pane we just added, so close it */