]> git.neil.brown.name Git - edlib.git/commitdiff
Send warning message when nested notification is prohibited.
authorNeilBrown <neil@brown.name>
Sun, 10 Sep 2023 09:41:04 +0000 (19:41 +1000)
committerNeilBrown <neil@brown.name>
Mon, 11 Sep 2023 02:16:50 +0000 (12:16 +1000)
As well a logging details - broadcast a message so nested notification
get noticed.

Signed-off-by: NeilBrown <neil@brown.name>
DOC/TODO.md
core-pane.c

index 7525cca16f4ed5362548ae0c266986f2a64d009b..689e924d9ca07662e854402bbaf014268fc97a31 100644 (file)
@@ -9,6 +9,8 @@ the file.
 
 ### Triage
 
+- [ ] adding new lines at end of doc in x11 leaves phantom underline
+      cursors.
 - [ ] 20230908090027.6AA0DC05B9@prodcs.lwn.net has a wrapped
       <a> tag which isn't parsed well.
 - [X] find-document - if default doc has <>, displays wrongly.
@@ -135,7 +137,7 @@ Core features
       care if the callback succeeded?
 - [ ] Change Efallthough to -1 so I can return '0' meaningfully.
       Efalse probably becomes 0.
-- [ ] send warning message when recursive notification is prohibited.
+- [X] send warning message when recursive notification is prohibited.
        editor:notify:Message:broadcast
 - [ ] Make DEF_CB really different from DEF_CMD and ensure it is used properly.
 - [X] is DocLeaf really a good idea?  Maybe panes should have 'leafward'
index 4594c7ed0463720206352726a7389d0647efee8d..f8ff319aeb45457c07b31a24bf464027d72176c2 100644 (file)
@@ -524,6 +524,9 @@ int do_pane_notify(struct pane *home, const char *notification safe,
                        LOG("Nested notification from %s to %s for %s not permitted.",
                            home->name, n->notifiee->name, notification);
                        LOG_BT();
+                       call("editor:notify:Message:broadcast",
+                            home, 0, NULL,
+                            "WARNING nested notification blocked - see log");
                        return Efail;
                }
 restart: