[PATCH] Print warning for common symbols in modules

From: Rusty Russell <rusty@rustcorp.com.au>

People still build modules wrong, particularly without -fno-common.  The
resulting modules don't load, but we should at least warn about it.

diff --git a/kernel/module.c b/kernel/module.c
index a472deef9bdf34665fd4ccc55c3fc59edfbb5dff..951b05f09ada35b8737a86ab66597544768c6e07 100644 (file)
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1003,6 +1003,8 @@ static int simplify_symbols(Elf_Shdr *sechdrs,
                        /* We compiled with -fno-common.  These are not
                           supposed to happen.  */
                        DEBUGP("Common symbol: %s\n", strtab + sym[i].st_name);
+                       printk("%s: please compile with -fno-common\n",
+                              mod->name);
                        ret = -ENOEXEC;
                        break;