[PATCH] kNFSd: Make sure export_open cleans up on failure.

Currently if the kmalloc in exports_open fails,
the seq_file isn't seq_released.

We now do the kmalloc first, and make sure to kfree
if seq_open fails.

diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 85ca18fe1b5086a64883080384ef2af83ee3e748..4d208cbaa5d9d304ed3d9ceba72398ccf8cba501 100644 (file)
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -127,14 +127,16 @@ extern struct seq_operations nfs_exports_op;
 static int exports_open(struct inode *inode, struct file *file)
 {
        int res;
+       char *namebuf = kmalloc(PAGE_SIZE, GFP_KERNEL);
+       if (namebuf == NULL)
+               return -ENOMEM;
+
        res = seq_open(file, &nfs_exports_op);
-       if (!res) {
-               char *namebuf = kmalloc(PAGE_SIZE, GFP_KERNEL);
-               if (namebuf == NULL)
-                       res = -ENOMEM;
-               else
-                       ((struct seq_file *)file->private_data)->private = namebuf;
-       }
+       if (res)
+               kfree(namebuf);
+       else
+               ((struct seq_file *)file->private_data)->private = namebuf;
+
        return res;
 }
 static int exports_release(struct inode *inode, struct file *file)