]> git.neil.brown.name Git - history.git/commitdiff
[PATCH] fs/proc/proc_tty.c: avoid array
authorDomen Puncer <domen@coderock.org>
Tue, 11 Jan 2005 01:18:29 +0000 (17:18 -0800)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Tue, 11 Jan 2005 01:18:29 +0000 (17:18 -0800)
No need for an array here.  Therefore no need to worry about possible
overflows.  seq_printf() can handle this.

Signed-off-by: walter harms <wharms@bfs.de>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/proc/proc_tty.c

index e4e2f6b5e9c1d6769c01a30d926792e5f6ee3318..15c4455b09eb33200adcc2c6984123fd7592083d 100644 (file)
@@ -32,10 +32,8 @@ static void show_tty_range(struct seq_file *m, struct tty_driver *p,
        seq_printf(m, "%-20s ", p->driver_name ? p->driver_name : "unknown");
        seq_printf(m, "/dev/%-8s ", p->name);
        if (p->num > 1) {
-               char    range[20];
-               sprintf(range, "%d-%d", MINOR(from),
+               seq_printf(m, "%3d %d-%d ", MAJOR(from), MINOR(from),
                        MINOR(from) + num - 1);
-               seq_printf(m, "%3d %7s ", MAJOR(from), range);
        } else {
                seq_printf(m, "%3d %7d ", MAJOR(from), MINOR(from));
        }