]> git.neil.brown.name Git - history.git/commitdiff
[tokenring smctr] fix MAC address input
authorJochen Friedrich <jochen@scram.de>
Thu, 13 Feb 2003 13:36:51 +0000 (08:36 -0500)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 13 Feb 2003 13:36:51 +0000 (08:36 -0500)
After taking a second look, i just recognized that both cases (MAC adress
all-zero or not) are handled exactly the same (by duplicated code), so the
whole stuff is unnecessary.

The whole function just reduces to a simple copy loop:

drivers/net/tokenring/smctr.c

index 76d010033b5b1ea7330d4086e12e789f61d4b496..3c506f7e8ff5254132610ff2952b6e78fc0b746f 100644 (file)
@@ -3063,28 +3063,12 @@ static int smctr_load_node_addr(struct net_device *dev)
         unsigned int i;
         __u8 r;
 
-        /* Check if node address has been specified by user. (non-0) */
-        for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++)
+        for(i = 0; i < 6; i++)
         {
-                if(i != 6)
-                {
-                        for(i = 0; i < 6; i++)
-                        {
-                                r = inb(ioaddr + LAR0 + i);
-                                dev->dev_addr[i] = (char)r;
-                        }
-                        dev->addr_len = 6;
-                }
-                else    /* Node addr. not given by user, read it from board. */
-                {
-                        for(i = 0; i < 6; i++)
-                        {
-                                r = inb(ioaddr + LAR0 + i);
-                                dev->dev_addr[i] = (char)r;
-                        }
-                        dev->addr_len = 6;
-                }
+                r = inb(ioaddr + LAR0 + i);
+                dev->dev_addr[i] = (char)r;
         }
+        dev->addr_len = 6;
 
         return (0);
 }