]> git.neil.brown.name Git - history.git/commitdiff
[PATCH] ext3 journalled quota locking fix
authorAndrew Morton <akpm@osdl.org>
Mon, 26 Apr 2004 15:56:01 +0000 (08:56 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Mon, 26 Apr 2004 15:56:01 +0000 (08:56 -0700)
From: Jan Kara <jack@ucw.cz>

I've attached a fix for a problem in ext3 journalled quota patch - the problem
is that detecting whether dqput() sleeps was wrong and so we could possibly
schedule when holding a spinlock.

fs/dquot.c

index 2c32d456cbaf149ac5f4639a410a7002f53f79e6..eabeb6d6d456a100a7137ee53adf5876812b6188 100644 (file)
@@ -642,7 +642,7 @@ restart:
 /* Return 0 if dqput() won't block (note that 1 doesn't necessarily mean blocking) */
 static inline int dqput_blocks(struct dquot *dquot)
 {
-       if (atomic_read(&dquot->dq_count) <= 1 && dquot_dirty(dquot))
+       if (atomic_read(&dquot->dq_count) <= 1)
                return 1;
        return 0;
 }