From: Dave Airlie Date: Sat, 12 Mar 2005 13:38:27 +0000 (-0800) Subject: [PATCH] drm missing memset can crash X server.. X-Git-Tag: v2.6.11.3~9 X-Git-Url: http://git.neil.brown.name/?a=commitdiff_plain;h=757d1be69c951b3d644318ca2a6f282904006bd0;p=history.git [PATCH] drm missing memset can crash X server.. Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it down to a missing memset in the setversion ioctl, this causes X server crashes... From: Egbert Eich Signed-off-by: Dave Airlie Signed-off-by: Chris Wright Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/drm/drm_ioctl.c b/drivers/char/drm/drm_ioctl.c index 616850974294..7621b35694db 100644 --- a/drivers/char/drm/drm_ioctl.c +++ b/drivers/char/drm/drm_ioctl.c @@ -326,6 +326,8 @@ int drm_setversion(DRM_IOCTL_ARGS) DRM_COPY_FROM_USER_IOCTL(sv, argp, sizeof(sv)); + memset(&version, 0, sizeof(version)); + dev->driver->version(&version); retv.drm_di_major = DRM_IF_MAJOR; retv.drm_di_minor = DRM_IF_MINOR;