From: Russell King <rmk@flint.arm.linux.org.uk>
Date: Tue, 23 Jul 2002 09:15:28 +0000 (+0100)
Subject: [SERIAL] Fix deadlock in __uart_start introduced in previous cset
X-Git-Tag: v2.5.28~7^2~1
X-Git-Url: http://git.neil.brown.name/?a=commitdiff_plain;h=8ff2d04390ed67d78d3168d2e47e2f9155a53816;p=history.git

[SERIAL] Fix deadlock in __uart_start introduced in previous cset
Thanks to Zwane Mwaikambo for finding this.
---

diff --git a/drivers/serial/core.c b/drivers/serial/core.c
index 724ad652e08f..026b54b191d6 100644
--- a/drivers/serial/core.c
+++ b/drivers/serial/core.c
@@ -104,13 +104,10 @@ static void __uart_start(struct tty_struct *tty)
 {
 	struct uart_info *info = tty->driver_data;
 	struct uart_port *port = info->port;
-	unsigned long flags;
 
-	spin_lock_irqsave(&port->lock, flags);
 	if (!uart_circ_empty(&info->xmit) && info->xmit.buf &&
 	    !tty->stopped && !tty->hw_stopped)
 		port->ops->start_tx(port, 1);
-	spin_unlock_irqrestore(&port->flags, flags);
 }
 
 static void uart_start(struct tty_struct *tty)