From: NeilBrown <neil@brown.name>
Date: Fri, 8 Sep 2023 09:58:25 +0000 (+1000)
Subject: text: don't use Free
X-Git-Url: http://git.neil.brown.name/?a=commitdiff_plain;h=a35f3ce4527a738702fb8b0288045e3e3d5fde01;p=edlib.git

text: don't use Free

There is no need to delay freeing of names to Free - do it in Close.

Signed-off-by: NeilBrown <neil@brown.name>
---

diff --git a/doc-text.c b/doc-text.c
index 0a315876..7f4ed194 100644
--- a/doc-text.c
+++ b/doc-text.c
@@ -2521,6 +2521,10 @@ DEF_CMD(text_destroy)
 	struct text *t = ci->home->doc_data;
 
 	text_cleanout(t);
+	free((void*)t->fname);
+	t->fname = NULL;
+	free((void*)t->autosave_name);
+	t->autosave_name = NULL;
 	return Efallthrough;
 }
 
@@ -2544,15 +2548,6 @@ DEF_CMD(text_clear)
 	return 1;
 }
 
-DEF_CMD(text_free)
-{
-	struct text *t = ci->home->doc_data;
-
-	free((void*)t->fname);
-	free((void*)t->autosave_name);
-	return 1;
-}
-
 void edlib_init(struct pane *ed safe)
 {
 	call_comm("global-set-command", ed, &text_new, 0, NULL,
@@ -2586,6 +2581,5 @@ void edlib_init(struct pane *ed safe)
 	key_add(text_map, "debug:validate-marks", &text_val_marks);
 
 	key_add(text_map, "Close", &text_destroy);
-	key_add(text_map, "Free", &text_free);
 	key_add(text_map, "get-attr", &text_get_attr);
 }