From 517acd7f1ea4605970fc0f09318c1be1c4ccad63 Mon Sep 17 00:00:00 2001
From: Andrew Morton <akpm@osdl.org>
Date: Sun, 18 Apr 2004 22:07:58 -0700
Subject: [PATCH] [PATCH] Warn if module_param and MODULE_PARM mixed

From: Rusty Russell <rusty@rustcorp.com.au>

From: Pavel Roskin <proski@gnu.org>

If you use both module_param (new) and MODULE_PARM (obsolete) in a module,
only the second gets recognised.  Warn.
---
 kernel/module.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/module.c b/kernel/module.c
index 951b05f09ada..5a9846bb1992 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1543,6 +1543,10 @@ static struct module *load_module(void __user *umod,
 				      / sizeof(struct obsolete_modparm),
 				      sechdrs, symindex,
 				      (char *)sechdrs[strindex].sh_addr);
+		if (setupindex)
+			printk(KERN_WARNING "%s: Ignoring new-style "
+			       "parameters in presence of obsolete ones\n",
+			       mod->name);
 	} else {
 		/* Size of section 0 is 0, so this works well if no params */
 		err = parse_args(mod->name, mod->args,
-- 
2.39.5